RE: [PATCH net-next v3 34/47] net: fman: Change return type of disable to void

From: Camelia Alexandra Groza
Date: Thu Jul 21 2022 - 09:09:28 EST


> -----Original Message-----
> From: Sean Anderson <sean.anderson@xxxxxxxx>
> Sent: Saturday, July 16, 2022 1:00
> To: David S . Miller <davem@xxxxxxxxxxxxx>; Jakub Kicinski
> <kuba@xxxxxxxxxx>; Madalin Bucur <madalin.bucur@xxxxxxx>;
> netdev@xxxxxxxxxxxxxxx
> Cc: Paolo Abeni <pabeni@xxxxxxxxxx>; Eric Dumazet
> <edumazet@xxxxxxxxxx>; linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; Russell
> King <linux@xxxxxxxxxxxxxxx>; linux-kernel@xxxxxxxxxxxxxxx; Sean Anderson
> <sean.anderson@xxxxxxxx>
> Subject: [PATCH net-next v3 34/47] net: fman: Change return type of disable
> to void
>
> When disabling, there is nothing we can do about errors. In fact, the
> only error which can occur is misuse of the API. Just warn in the mac
> driver instead.
>
> Signed-off-by: Sean Anderson <sean.anderson@xxxxxxxx>

Acked-by: Camelia Groza <camelia.groza@xxxxxxx>