Re: [PATCH V6 02/16] rv: Add runtime reactors interface

[Tao Zhou]

On Tue, Jul 19, 2022 at 07:27:07PM +0200, Daniel Bristot de Oliveira wrote:

> diff --git a/include/linux/rv.h b/include/linux/rv.h
> index b6bcdb4888e6..4f5b70eee557 100644
> --- a/include/linux/rv.h
> +++ b/include/linux/rv.h
> @@ -7,6 +7,12 @@
>  #ifndef _LINUX_RV_H
>  #define _LINUX_RV_H
>  
> +struct rv_reactor {
> +	char			*name;
> +	char			*description;
> +	void			(*react)(char *msg);
> +};

Like the definition of name and description in structure rv_monitor,
use `const char *` for name and description.

> +#ifdef CONFIG_RV_REACTORS
> +struct rv_reactor_def {
> +	struct list_head	list;
> +	struct rv_reactor	*reactor;
> +	/* protected by the monitor interface lock */
> +	int			counter;

Not see the `counter` be used(inc/dec).

> +};
> +#endif