Re: [PATCH] kallsyms: make arch_get_kallsym() static

From: Christoph Hellwig
Date: Thu Jul 21 2022 - 11:22:45 EST


On Thu, Jul 21, 2022 at 04:10:40PM +0100, Ben Dooks wrote:
> The arch_get_kallsym() function is not used anywhere in the kernel
> now, so it should at-least be static or just be removed as there
> are no users. Making it static fixes the following sparse warning:
>
> kernel/kallsyms.c:590:12: warning: symbol 'arch_get_kallsym' was not declared. Should it be static?

It fixes the warning, but isn't exactly useful. Please just remove it,
get_ksymbol_arch and iter->pos_arch_end entirely instead.