Re: [PATCH v3 2/2] printk: console: Support console-specific loglevels

From: Chris Down
Date: Thu Jul 21 2022 - 12:30:07 EST


kernel test robot writes:
sparse warnings: (new ones prefixed by >>)
kernel/printk/sysctl.c:31:47: sparse: sparse: incorrect type in argument 3 (different address spaces) @@ expected void * @@ got void [noderef] __user *buffer @@
kernel/printk/sysctl.c:31:47: sparse: expected void *
kernel/printk/sysctl.c:31:47: sparse: got void [noderef] __user *buffer

Ah, since commit 32927393dc1c ("sysctl: pass kernel pointers to ->proc_handler") we copy to kernelspace before passing to the callback, so it's not a userspace pointer. That's certainly an improvement.

Will fix for v4.