Re: [PATCH RESEND] scripts/gdb: Fix gdb 'lx-symbols' command

[Luis Chamberlain]

On Thu, Jul 21, 2022 at 09:24:31AM -0700, Doug Anderson wrote:
> Hi,
> 
> On Thu, Jul 21, 2022 at 2:31 AM Khalid Masum <khalid.masum.92@xxxxxxxxx> wrote:
> >
> > Currently the command 'lx-symbols' in gdb exits with the error`Function
> > "do_init_module" not defined in "kernel/module.c"`. This occurs because
> > the file kernel/module.c was moved to kernel/module/main.c.
> >
> > Fix this breakage by changing the path to "kernel/module/main.c" in
> > LoadModuleBreakpoint.
> >
> > Signed-off-by: Khalid Masum <khalid.masum.92@xxxxxxxxx>
> > ---
> >  scripts/gdb/linux/symbols.py | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/scripts/gdb/linux/symbols.py b/scripts/gdb/linux/symbols.py
> > index 46f7542db08c..dc07b6d12e30 100644
> > --- a/scripts/gdb/linux/symbols.py
> > +++ b/scripts/gdb/linux/symbols.py
> > @@ -180,7 +180,7 @@ lx-symbols command."""
> >                  self.breakpoint.delete()
> >                  self.breakpoint = None
> >              self.breakpoint = LoadModuleBreakpoint(
> > -                "kernel/module.c:do_init_module", self)
> > +                "kernel/module/main.c:do_init_module", self)
> 
> Fixes: cfc1d277891e ("module: Move all into module/")
> Reviewed-by: Douglas Anderson <dianders@xxxxxxxxxxxx>

Acked-by: Luis Chamberlain <mcgrof@xxxxxxxxxx>

This should go to Linus prior to the next rc.  Linus, I think this is
with picking up now as I smell a final release soon.

FWIW a git grep of "kernel/module\.c" reveals no other code users of
this path.

  Luis