Re: [PATCH] ASoC: cs35l41: Set the new legacy DAI naming flag

[Cristian Ciocaltea]

On 7/21/22 17:54, Cristian Ciocaltea wrote:
> Hi Charles,
>
> On 7/21/22 16:19, Charles Keepax wrote:
> > On Thu, Jul 21, 2022 at 03:14:54PM +0300, Cristian Ciocaltea wrote:
> > > Unlike most CODEC drivers, the CS35L41 driver did not have the
> > > non_legacy_dai_naming set, meaning it uses the legacy naming.
> > >
> > > The recent migration to the new legacy DAI naming style has broken
> > > driver functionality because it is now expected to set the new legacy
> > > DAI naming flag in order to instruct the core subsystem to use the
> > > legacy name format on DAI registration.
> > >
> > > Let's fix this by setting the legacy_dai_naming flag accordingly.
> > >
> > > Fixes: bc949a3b4af3 ("ASoC: core: Switch core to new DAI naming flag")
> > > Signed-off-by: Cristian Ciocaltea <cristian.ciocaltea@xxxxxxxxxxxxx>
> > > ---
> >
> > It is really not intended for any CODECs to be using the legacy
> > DAI naming, it was only intended for platform side components.
> > Would be good if you had some details on the affected system and
> > if that could be updated to use the non legacy DAI naming?
>
> I'm currently testing this on Valve's Steam Deck. Let me also check what 
> would be the required changes in order to switch to using a non-legacy 
> DAI naming.

I have just submitted a (proper) fix:
https://lore.kernel.org/all/20220721233227.1459374-1-cristian.ciocaltea@xxxxxxxxxxxxx/

Thanks,
Cristian

> > Thanks,
> > Charles