RE: [PATCH 5/5] ASoC: amd: enable RPL Platform acp drivers build

[Saba Kareem, Syed]

[AMD Official Use Only - General]



-----Original Message-----
From: Randy Dunlap <rdunlap@xxxxxxxxxxxxx> 
Sent: Thursday, July 21, 2022 7:32 PM
To: Saba Kareem, Syed <Syed.SabaKareem@xxxxxxx>; broonie@xxxxxxxxxx; alsa-devel@xxxxxxxxxxxxxxxx
Cc: Deucher, Alexander <Alexander.Deucher@xxxxxxx>; Hiregoudar, Basavaraj <Basavaraj.Hiregoudar@xxxxxxx>; Dommati, Sunil-kumar <Sunil-kumar.Dommati@xxxxxxx>; Mukunda, Vijendar <Vijendar.Mukunda@xxxxxxx>; Liam Girdwood <lgirdwood@xxxxxxxxx>; Jaroslav Kysela <perex@xxxxxxxx>; Takashi Iwai <tiwai@xxxxxxxx>; Ajit Kumar Pandey <AjitKumar.Pandey@xxxxxxx>; Pierre-Louis Bossart <pierre-louis.bossart@xxxxxxxxxxxxxxx>; Daniel Baluta <daniel.baluta@xxxxxxx>; Lucas Tanure <tanureal@xxxxxxxxxxxxxxxxxxxxx>; Julian Braha <julianbraha@xxxxxxxxx>; Bard Liao <bard.liao@xxxxxxxxx>; open list <linux-kernel@xxxxxxxxxxxxxxx>
Subject: Re: [PATCH 5/5] ASoC: amd: enable RPL Platform acp drivers build

[CAUTION: External Email]

Hi--

On 7/20/22 23:10, syed sabakareem wrote:
> diff --git a/sound/soc/amd/Kconfig b/sound/soc/amd/Kconfig index 
> 9c2fef2ce89f..08f5289dac54 100644
> --- a/sound/soc/amd/Kconfig
> +++ b/sound/soc/amd/Kconfig
> @@ -117,3 +117,13 @@ config SND_AMD_ACP_CONFIG
>        driver modules to use
>
>  source "sound/soc/amd/acp/Kconfig"
> +
> +config SND_SOC_AMD_RPL_ACP6x
> +        tristate "AMD Audio Coprocessor-v6.2 RPL support"
> +        depends on X86 && PCI
> +        help
> +          This option enables Audio Coprocessor i.e ACP v6.2 support 
> +on

If that "i.e" is supposed to mean "that is", then it should be "i.e.".
Or does it mean something else here?

It is a typo mistake. Will correct it.
> +          AMD RPL platform. By enabling this flag build will be
> +          triggered for ACP PCI driver.
> +          Say m if you have such a device.
> +          If unsure select "N".

--
~Randy