RE: [PATCH net-next v3 27/47] net: fman: Inline several functions into initialization

[Camelia Alexandra Groza]

> -----Original Message-----
> From: Sean Anderson <sean.anderson@xxxxxxxx>
> Sent: Thursday, July 21, 2022 18:34
> To: Camelia Alexandra Groza <camelia.groza@xxxxxxx>; David S . Miller
> <davem@xxxxxxxxxxxxx>; Jakub Kicinski <kuba@xxxxxxxxxx>; Madalin Bucur
> <madalin.bucur@xxxxxxx>; netdev@xxxxxxxxxxxxxxx
> Cc: Paolo Abeni <pabeni@xxxxxxxxxx>; Eric Dumazet
> <edumazet@xxxxxxxxxx>; linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; Russell
> King <linux@xxxxxxxxxxxxxxx>; linux-kernel@xxxxxxxxxxxxxxx
> Subject: Re: [PATCH net-next v3 27/47] net: fman: Inline several functions
> into initialization
> 
> 
> 
> On 7/21/22 9:01 AM, Camelia Alexandra Groza wrote:
> >> -----Original Message-----
> >> From: Sean Anderson <sean.anderson@xxxxxxxx>
> >> Sent: Saturday, July 16, 2022 1:00
> >> To: David S . Miller <davem@xxxxxxxxxxxxx>; Jakub Kicinski
> >> <kuba@xxxxxxxxxx>; Madalin Bucur <madalin.bucur@xxxxxxx>;
> >> netdev@xxxxxxxxxxxxxxx
> >> Cc: Paolo Abeni <pabeni@xxxxxxxxxx>; Eric Dumazet
> >> <edumazet@xxxxxxxxxx>; linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; Russell
> >> King <linux@xxxxxxxxxxxxxxx>; linux-kernel@xxxxxxxxxxxxxxx; Sean
> Anderson
> >> <sean.anderson@xxxxxxxx>
> >> Subject: [PATCH net-next v3 27/47] net: fman: Inline several functions
> into
> >> initialization
> >>
> >> There are several small functions which weer only necessary because the
> >
> > *were* typo.
> 
> Hm, I thought commit messages were supposed to be written as if the patch
> hadn't
> yet been applied (e.g. the current state as the patch is reviewed).

That's my understanding as well. I was pointing out this bit: "which weer only necessary ".
I assume you wanted to type "were" here.

> >> initialization functions didn't have access to the mac private data. Now
> >> that they do, just do things directly.
> >>
> >> Signed-off-by: Sean Anderson <sean.anderson@xxxxxxxx>
> >
> > Acked-by: Camelia Groza <camelia.groza@xxxxxxx>
> >