Re: [PATCH v2 5/5] Documentation: driver-api: visconti: add a description of DNN driver.

From: Jonathan Corbet
Date: Fri Jul 22 2022 - 09:33:05 EST


Yuji Ishikawa <yuji2.ishikawa@xxxxxxxxxxxxx> writes:

No changelog?

> Signed-off-by: Yuji Ishikawa <yuji2.ishikawa@xxxxxxxxxxxxx>
> ---
> v1 -> v2:
> - newly added documents
> ---
> Documentation/driver-api/visconti/common.rst | 115 ++++++
> Documentation/driver-api/visconti/dnn.rst | 394 +++++++++++++++++++
> 2 files changed, 509 insertions(+)
> create mode 100644 Documentation/driver-api/visconti/common.rst
> create mode 100644 Documentation/driver-api/visconti/dnn.rst

Two overall comments:

- You've added new RST files without adding them to index.rst; that
will keep them from being part of the kernel docs build and will add
new warnings.

- Please avoid the use of flat-table and just use regular RST
ascii-art tables. Otherwise the result is nearly unreadable in the
plain-test format.

Thanks,

jon