Re: [PATCH v2 2/2] spi: npcm-pspi: Add NPCM845 peripheral SPI support

[Mark Brown]

On Fri, Jul 22, 2022 at 08:31:22PM +0200, Krzysztof Kozlowski wrote:
> On 22/07/2022 13:41, Tomer Maimon wrote:

> >  static const struct of_device_id npcm_pspi_match[] = {
> >  	{ .compatible = "nuvoton,npcm750-pspi", .data = NULL },
> > +	{ .compatible = "nuvoton,npcm845-pspi", .data = NULL },

> The devices look compatible, so why not reusing 750 compatible and
> adding more specific upfront only in the bindings instead?

...with a fallback list required by the bindings so the driver actually
binds.  Note that bindings are currently not in YAML format so there'd
be even less enforcement of that than normal, and as they're currently
written the bindings don't require fallback.

Attachment: signature.asc
Description: PGP signature