[ammarfaizi2-block:tj/cgroup/for-next 7/8] kernel/cgroup/cgroup.c:1310:39: error: 'CGRP_ROOT_FAVOR_DYNMODS' undeclared
From: kernel test robot
Date: Sat Jul 23 2022 - 03:50:29 EST
tree: https://github.com/ammarfaizi2/linux-block tj/cgroup/for-next
head: c87b1452249c69cdec70d5de64ea81f56e1ba3f8
commit: 79276d9e0dda30071b9a98045a3efa7e0a76938b [7/8] cgroup: Make !percpu threadgroup_rwsem operations optional
config: arm64-buildonly-randconfig-r001-20220721 (https://download.01.org/0day-ci/archive/20220723/202207231547.F1PGIJ5n-lkp@xxxxxxxxx/config)
compiler: aarch64-linux-gcc (GCC) 12.1.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/ammarfaizi2/linux-block/commit/79276d9e0dda30071b9a98045a3efa7e0a76938b
git remote add ammarfaizi2-block https://github.com/ammarfaizi2/linux-block
git fetch --no-tags ammarfaizi2-block tj/cgroup/for-next
git checkout 79276d9e0dda30071b9a98045a3efa7e0a76938b
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=arm64 SHELL=/bin/bash kernel/cgroup/
If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@xxxxxxxxx>
All error/warnings (new ones prefixed by >>):
>> kernel/cgroup/cgroup.c:1308:6: warning: no previous prototype for 'cgroup_favor_dynmods' [-Wmissing-prototypes]
1308 | void cgroup_favor_dynmods(struct cgroup_root *root, bool favor)
| ^~~~~~~~~~~~~~~~~~~~
kernel/cgroup/cgroup.c: In function 'cgroup_favor_dynmods':
>> kernel/cgroup/cgroup.c:1310:39: error: 'CGRP_ROOT_FAVOR_DYNMODS' undeclared (first use in this function)
1310 | bool favoring = root->flags & CGRP_ROOT_FAVOR_DYNMODS;
| ^~~~~~~~~~~~~~~~~~~~~~~
kernel/cgroup/cgroup.c:1310:39: note: each undeclared identifier is reported only once for each function it appears in
kernel/cgroup/cgroup.c: In function 'cgroup2_parse_param':
kernel/cgroup/cgroup.c:1912:31: error: 'CGRP_ROOT_FAVOR_DYNMODS' undeclared (first use in this function)
1912 | ctx->flags |= CGRP_ROOT_FAVOR_DYNMODS;
| ^~~~~~~~~~~~~~~~~~~~~~~
kernel/cgroup/cgroup.c: In function 'apply_cgroup_root_flags':
kernel/cgroup/cgroup.c:1942:51: error: 'CGRP_ROOT_FAVOR_DYNMODS' undeclared (first use in this function)
1942 | root_flags & CGRP_ROOT_FAVOR_DYNMODS);
| ^~~~~~~~~~~~~~~~~~~~~~~
kernel/cgroup/cgroup.c: In function 'cgroup_show_options':
kernel/cgroup/cgroup.c:1960:35: error: 'CGRP_ROOT_FAVOR_DYNMODS' undeclared (first use in this function)
1960 | if (cgrp_dfl_root.flags & CGRP_ROOT_FAVOR_DYNMODS)
| ^~~~~~~~~~~~~~~~~~~~~~~
kernel/cgroup/cgroup.c: In function 'init_cgroup_root':
kernel/cgroup/cgroup.c:2013:37: error: 'CGRP_ROOT_FAVOR_DYNMODS' undeclared (first use in this function)
2013 | root->flags = ctx->flags & ~CGRP_ROOT_FAVOR_DYNMODS;
| ^~~~~~~~~~~~~~~~~~~~~~~
--
kernel/cgroup/cgroup-v1.c: In function 'cgroup1_show_options':
>> kernel/cgroup/cgroup-v1.c:878:27: error: 'CGRP_ROOT_FAVOR_DYNMODS' undeclared (first use in this function)
878 | if (root->flags & CGRP_ROOT_FAVOR_DYNMODS)
| ^~~~~~~~~~~~~~~~~~~~~~~
kernel/cgroup/cgroup-v1.c:878:27: note: each undeclared identifier is reported only once for each function it appears in
kernel/cgroup/cgroup-v1.c: In function 'cgroup1_parse_param':
kernel/cgroup/cgroup-v1.c:970:31: error: 'CGRP_ROOT_FAVOR_DYNMODS' undeclared (first use in this function)
970 | ctx->flags |= CGRP_ROOT_FAVOR_DYNMODS;
| ^~~~~~~~~~~~~~~~~~~~~~~
kernel/cgroup/cgroup-v1.c: In function 'cgroup1_root_to_use':
>> kernel/cgroup/cgroup-v1.c:1227:17: error: implicit declaration of function 'cgroup_favor_dynmods' [-Werror=implicit-function-declaration]
1227 | cgroup_favor_dynmods(root, ctx->flags & CGRP_ROOT_FAVOR_DYNMODS);
| ^~~~~~~~~~~~~~~~~~~~
kernel/cgroup/cgroup-v1.c:1227:57: error: 'CGRP_ROOT_FAVOR_DYNMODS' undeclared (first use in this function)
1227 | cgroup_favor_dynmods(root, ctx->flags & CGRP_ROOT_FAVOR_DYNMODS);
| ^~~~~~~~~~~~~~~~~~~~~~~
cc1: some warnings being treated as errors
vim +/CGRP_ROOT_FAVOR_DYNMODS +1310 kernel/cgroup/cgroup.c
1307
> 1308 void cgroup_favor_dynmods(struct cgroup_root *root, bool favor)
1309 {
> 1310 bool favoring = root->flags & CGRP_ROOT_FAVOR_DYNMODS;
1311
1312 /* see the comment above CGRP_ROOT_FAVOR_DYNMODS definition */
1313 if (favor && !favoring) {
1314 rcu_sync_enter(&cgroup_threadgroup_rwsem.rss);
1315 root->flags |= CGRP_ROOT_FAVOR_DYNMODS;
1316 } else if (!favor && favoring) {
1317 rcu_sync_exit(&cgroup_threadgroup_rwsem.rss);
1318 root->flags &= ~CGRP_ROOT_FAVOR_DYNMODS;
1319 }
1320 }
1321
--
0-DAY CI Kernel Test Service
https://01.org/lkp