Re: [PATCH v2] drivers: lkdtm: fix clang -Wformat warning

[Kees Cook]

On July 21, 2022 2:57:06 PM PDT, Justin Stitt <justinstitt@xxxxxxxxxx> wrote:
>When building with Clang we encounter the following warning
>(ARCH=hexagon + CONFIG_FRAME_WARN=0):
>| ../drivers/misc/lkdtm/bugs.c:107:3: error: format specifies type
>| 'unsigned long' but the argument has type 'int' [-Werror,-Wformat]
>|                 REC_STACK_SIZE, recur_count);
>|                 ^~~~~~~~~~~~~~
>
>Cast REC_STACK_SIZE to `unsigned long` to match format specifier `%lu`
>as well as maintain symmetry with `#define REC_STACK_SIZE
>(_AC(CONFIG_FRAME_WARN, UL) / 2)`.
>
>Link: https://github.com/ClangBuiltLinux/linux/issues/378
>Reported-by: Nathan Chancellor <nathan@xxxxxxxxxx>
>Suggested-by: Nathan Chancellor <nathan@xxxxxxxxxx>
>Suggested-by: Nick Desaulniers <ndesaulniers@xxxxxxxxxx>
>Signed-off-by: Justin Stitt <justinstitt@xxxxxxxxxx>

Thanks!

Acked-by: Kees Cook <keescook@xxxxxxxxxxxx>
Fixes: 24cccab42c419 ("lkdtm/bugs: Adjust recursion test to avoid elision")


-- 
Kees Cook