Re: [PATCH] kernel/watch_queue: Make pipe NULL while clearing watch_queue

From: Siddh Raman Pant
Date: Sat Jul 23 2022 - 10:30:36 EST


On Sat, 23 Jul 2022 19:33:33 +0530 Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx> wrote:
> You should not use #ifdef in .c files, it's unmaintainable over time.
>
> thanks,
>
> greg k-h
>

I used it because it is used in the same way in fs/pipe.c too (please check the
stated line number).

That, in turn, is because `watch_queue` member in the `pipe_inode_info` struct
is defined that way (see line 80 of include/linux/pipe_fs_i.h), so I am forced
to use the ifdef guard.

Thanks,
Siddh