Re: [PATCH 1/2] scsi: ufs: Add Multi-Circular Queue support

From: Bart Van Assche
Date: Sat Jul 23 2022 - 23:16:06 EST


On 7/23/22 08:26, Avri Altman wrote:
+
+ /* sqen|size|cqid */
+ ufsmcq_writel(hba, (1 << 31) | qsize | (i << 16),
+ MCQ_CFG_n(REG_SQATTR, i));
So there is a 1X1 SQ-CQ topology.
Isn't that should be configurable?

Hi Avri,

I'm in favor of starting with a 1:1 SQ:CQ mapping and only adding support for other approaches if there is a very good reason.

Thanks,

Bart.