Re: [PATCH AUTOSEL 5.18 28/54] tty: Add N_CAN327 line discipline ID for ELM327 based CAN driver

[Jiri Slaby]

On 20. 07. 22, 3:10, Sasha Levin wrote:
> From: Max Staudt <max@xxxxxxxxx>
>
> [ Upstream commit ec5ad331680c96ef3dd30dc297b206988023b9e1 ]
>
> The actual driver will be added via the CAN tree.

Hmm, it's a new driver (ldisc). Should it really go to stable?

> Acked-by: Marc Kleine-Budde <mkl@xxxxxxxxxxxxxx>
> Signed-off-by: Max Staudt <max@xxxxxxxxx>
> Link: https://lore.kernel.org/r/20220618180134.9890-1-max@xxxxxxxxx
> Signed-off-by: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
> Signed-off-by: Sasha Levin <sashal@xxxxxxxxxx>
> ---
>   include/uapi/linux/tty.h | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/include/uapi/linux/tty.h b/include/uapi/linux/tty.h
> index 9d0f06bfbac3..68aeae2addec 100644
> --- a/include/uapi/linux/tty.h
> +++ b/include/uapi/linux/tty.h
> @@ -38,8 +38,9 @@
>   #define N_NULL		27	/* Null ldisc used for error handling */
>   #define N_MCTP		28	/* MCTP-over-serial */
>   #define N_DEVELOPMENT	29	/* Manual out-of-tree testing */
> +#define N_CAN327	30	/* ELM327 based OBD-II interfaces */
>   
>   /* Always the newest line discipline + 1 */
> -#define NR_LDISCS	30
> +#define NR_LDISCS	31
>   
>   #endif /* _UAPI_LINUX_TTY_H */


--
js
suse labs