Re: [PATCH v2 1/3] dt-bindings: net: cdns,macb: Add versal compatible string

[Krzysztof Kozlowski]

On 25/07/2022 21:33, Rob Herring wrote:
> On Fri, Jul 22, 2022 at 04:33:28PM +0530, Harini Katakam wrote:
>> From: Radhey Shyam Pandey <radhey.shyam.pandey@xxxxxxxxxx>
>>
>> Add versal compatible string.
>>
>> Signed-off-by: Radhey Shyam Pandey <radhey.shyam.pandey@xxxxxxxxxx>
>> Signed-off-by: Harini Katakam <harini.katakam@xxxxxxxxxx>
>> ---
>> v2:
>> Sort compatible string alphabetically.
>>
>>  Documentation/devicetree/bindings/net/cdns,macb.yaml | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/Documentation/devicetree/bindings/net/cdns,macb.yaml b/Documentation/devicetree/bindings/net/cdns,macb.yaml
>> index 9c92156869b2..762deccd3640 100644
>> --- a/Documentation/devicetree/bindings/net/cdns,macb.yaml
>> +++ b/Documentation/devicetree/bindings/net/cdns,macb.yaml
>> @@ -20,6 +20,7 @@ properties:
>>  
>>        - items:
>>            - enum:
>> +              - cdns,versal-gem       # Xilinx Versal
>>                - cdns,zynq-gem         # Xilinx Zynq-7xxx SoC
>>                - cdns,zynqmp-gem       # Xilinx Zynq Ultrascale+ MPSoC
> 
> Uh, how did we start this pattern? The vendor here is Xilinx, not 
> Cadence. It should be xlnx,versal-gem instead.

I missed that piece entirely... Un-ack.

Best regards,
Krzysztof