Re: [PATCH] gpio: gpio-xilinx: Fix integer overflow

[Andy Shevchenko]

On Mon, Jul 25, 2022 at 10:04 PM Andy Shevchenko
<andy.shevchenko@xxxxxxxxx> wrote:
> On Fri, Jul 22, 2022 at 9:19 AM Bartosz Golaszewski <brgl@xxxxxxxx> wrote:
> > On Thu, Jul 21, 2022 at 9:39 AM Srinivas Neeli
> > <srinivas.neeli@xxxxxxxxxx> wrote:
> > >
> > > Current implementation is not able to configure more than 32 pins
> > > due to incorrect data type. So type casting with unsigned long
> > > to avoid it.
>
> > > Fixes: 02b3f84d9080 ("xilinx: Switch to use bitmap APIs")
>
> It doesn't fix anything,  I already reject one such "fix" during
> development of this patch. Thanks!

Sorry, not my day, it was something else that time... See below.

> ...
>
> > > @@ -99,7 +99,7 @@ c
>
> > Applied, thanks!
>
> False positive.

Reading again... You mean that

  unsigned long x = y << 32;

wouldn't work?



-- 
With Best Regards,
Andy Shevchenko