Re: [PATCH v4 5/5] iio: pressure: bmp280: Add more tunable config parameters for BMP380

From: Andy Shevchenko
Date: Mon Jul 25 2022 - 17:20:09 EST


On Sat, Jul 23, 2022 at 7:40 PM Angel Iglesias <ang.iglesiasg@xxxxxxxxx> wrote:
>
> Allows sampling frequency and IIR filter coefficients configuration
> using sysfs ABI.
>
> The IIR filter coefficient is configurable using the sysfs attribute
> "filter_low_pass_3db_frequency".
>
> Signed-off-by: Angel Iglesias <ang.iglesiasg@xxxxxxxxx>

> Reported-by: Andy Shevchenko <andy.shevchenko@xxxxxxxxx> # uninit var

Bugs in new features can't have Reported-by tag.

If you wish to give credit, use a cover letter / changelog.

...

> + /*
> + * Configuration errors are detected on the fly during a measurement

The configurations

> + * cycle. If the sampling frequency is too low, it's faster to reset
> + * measurement loop than wait until next measurement is due.

the measurement
the next

> + * Resets sensor measurement loop toggling between sleep and normal
> + * operating modes.
> + */

--
With Best Regards,
Andy Shevchenko