Re: [PATCH v2 1/1] spi/panel: dt-bindings: drop CPHA and CPOL from common properties

From: Rob Herring
Date: Mon Jul 25 2022 - 19:14:17 EST


On Fri, 22 Jul 2022 21:15:39 +0200, Krzysztof Kozlowski wrote:
> The spi-cpha and spi-cpol properties are device specific and should be
> accepted only if device really needs them. Drop them from common
> spi-peripheral-props.yaml schema, mention in few panel drivers which use
> them and include instead in the SPI controller bindings. The controller
> bindings will provide CPHA/CPOL type validation and one place for
> description. Each device schema must list the properties if they are
> applicable.
>
> Suggested-by: Jonathan Cameron <jic23@xxxxxxxxxx>
> Suggested-by: Rob Herring <robh@xxxxxxxxxx>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
> ---
> .../bindings/display/panel/lgphilips,lb035q02.yaml | 3 +++
> .../bindings/display/panel/samsung,ld9040.yaml | 3 +++
> .../bindings/display/panel/sitronix,st7789v.yaml | 3 +++
> .../devicetree/bindings/display/panel/tpo,td.yaml | 3 +++
> .../devicetree/bindings/spi/spi-controller.yaml | 11 +++++++++++
> .../devicetree/bindings/spi/spi-peripheral-props.yaml | 10 ----------
> 6 files changed, 23 insertions(+), 10 deletions(-)
>

Reviewed-by: Rob Herring <robh@xxxxxxxxxx>

Unless Mark doesn't want to pick this up.