Re: [PATCH 2/4] firmware: Samsung: Add secure monitor driver

[Krzysztof Kozlowski]

On 26/07/2022 02:04, Dongjin Yang wrote:
> 
> On 14/07/2022 04:28, Krzysztof Kozlowski wrote:
>> On 13/07/2022 06:55, Dongjin Yang wrote:
>>>  Introduce a driver to provide calls into secure monitor mode.
>>>  This driver is used for SoCs produced by Samsung Foundry to provide
>>>  SMC call. This patch supports register read/write request to secure
>>>  monitor. Also, SMC call request which uses shared memory to exchange
>>>  the data between kernel and secure monitor.
>>>  
>>>  Signed-off-by: Dongjin Yang <dj76.yang@xxxxxxxxxxx>
>>>  ---
>>>   MAINTAINERS                              |   2 +
>>>   drivers/firmware/Kconfig                 |  11 +++
>>>   drivers/firmware/Makefile                |   1 +
>>>   drivers/firmware/samsung-smc-svc.c       | 154 +++++++++++++++++++++++++++++++
>>>   include/linux/firmware/samsung-smc-svc.h |  59 ++++++++++++
>>>   5 files changed, 227 insertions(+)
>>>   create mode 100644 drivers/firmware/samsung-smc-svc.c
>>>   create mode 100644 include/linux/firmware/samsung-smc-svc.h
>>>  
>>>  diff --git a/MAINTAINERS b/MAINTAINERS
>>>  index 6763746c349f..d173043ffb46 100644
>>>  --- a/MAINTAINERS
>>>  +++ b/MAINTAINERS
>>>  @@ -1868,8 +1868,10 @@ F:        arch/arm/boot/dts/artpec6*
>>>   F:        arch/arm/mach-artpec
>>>   F:        drivers/clk/axis
>>>   F:        drivers/crypto/axis
>>>  +F:        drivers/firmware/samsung-smc-svc.c
>>>   F:        drivers/mmc/host/usdhi6rol0.c
>>>   F:        drivers/pinctrl/pinctrl-artpec*
>>>  +F:        include/linux/firmware/samsung-smc-svc.h
>>
>> Same as for bindings - not related to Artpec platforms. Either add
>> dedicated entry or put it under Samsung SoC.
>>
> 
> This patch is for Artpec8 SoC.

This does not answer my comment at all.


> 


Best regards,
Krzysztof