Re: [linux][PATCH v1 1/1] dts: arm: at91: Add SAMA5D3-EDS Board

From: Claudiu.Beznea
Date: Tue Jul 26 2022 - 04:30:48 EST

Next message: Daniel Bristot de Oliveira: "Re: [PATCH v2] rtla: Define syscall numbers for riscv"
Previous message: Andy Shevchenko: "[PATCH v1 1/1] asm-generic: Make parameter types consisten in _unaligned_be48()"
In reply to: Jerry Ray: "[linux][PATCH v1 1/1] dts: arm: at91: Add SAMA5D3-EDS Board"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

On 25.07.2022 19:22, Jerry Ray wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
>
> Adding device tree supporting for the SAMA5D3 Ethernet Development
> System board.
> https://www.microchip.com/en-us/development-tool/SAMA5D3-ETHERNET-DEVELOPMENT-SYSTEM

I don't think this is needed as the link might change over time and point
to nothing. Instead a board description would be better.

>
> Modifying the Makefile to include building the file.

This is not needed.

>
> Signed-off-by: Jerry Ray <jerry.ray@xxxxxxxxxxxxx>
> ---
> arch/arm/boot/dts/Makefile | 1 +
> arch/arm/boot/dts/at91-sama5d3_eds.dts | 367 +++++++++++++++++++++++++
> 2 files changed, 368 insertions(+)
> create mode 100644 arch/arm/boot/dts/at91-sama5d3_eds.dts
>
> diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
> index 112931c17a40..29defb067123 100644
> --- a/arch/arm/boot/dts/Makefile
> +++ b/arch/arm/boot/dts/Makefile
> @@ -61,6 +61,7 @@ dtb-$(CONFIG_SOC_SAM_V7) += \
> at91-sama5d2_icp.dtb \
> at91-sama5d2_ptc_ek.dtb \
> at91-sama5d2_xplained.dtb \
> + at91-sama5d3_eds.dtb \
> at91-sama5d3_xplained.dtb \
> at91-dvk_som60.dtb \
> at91-gatwick.dtb \
> diff --git a/arch/arm/boot/dts/at91-sama5d3_eds.dts b/arch/arm/boot/dts/at91-sama5d3_eds.dts
> new file mode 100644
> index 000000000000..7885c296e0fb
> --- /dev/null
> +++ b/arch/arm/boot/dts/at91-sama5d3_eds.dts
> @@ -0,0 +1,367 @@
> +// SPDX-License-Identifier: GPL-2.0-or-later
> +/*
> + * at91-sama5d3_eds.dts - Device Tree file for the SAMA5D3 Ethernet
> + * Development System board.
> + *
> + * Copyright (C) 2022 Microchip Technology, Inc. and its subsidiaries
> + * 2022 Jerry Ray <jerry.ray@xxxxxxxxxxxxx>
> + */
> +/dts-v1/;
> +#include "sama5d36.dtsi"
> +
> +/ {
> + model = "SAMA5D3 Ethernet Development System";
> + compatible = "atmel,sama5d3-xplained", "atmel,sama5d3", "atmel,sama5";
> +
> + chosen {
> + stdout-path = "serial0:115200n8";
> + };
> +
> + memory@20000000 {
> + reg = <0x20000000 0x10000000>;
> + };
> +
> + clocks {
> + slow_xtal {
> + clock-frequency = <32768>;
> + };
> +
> + main_xtal {
> + clock-frequency = <12000000>;
> + };
> + };
> +
> + ahb {
> + apb {
> + can0: can@f000c000 {
> + status = "okay";
> + };

Please follow the style:

&can0 {
status = "okay";
};

for all the enabled IPs. See other recently added boards (e.g.
arch/arm/boot/dts/lan966x-pcb8291.dts)

> +
> + macb0: ethernet@f0028000 {
> + phy-mode = "rgmii-id";
> + #address-cells = <1>;
> + #size-cells = <0>;

You don't need #address-cells, #size-cells here.

> + local-mac-address = [00 00 00 00 00 00];
> + status = "disabled";

Is threre a reason you have bindings for this node but you don't keep it
enabled?

> + };
> +
> + macb1: ethernet@f802c000 {
> + phy-mode = "rmii";
> + #address-cells = <1>;
> + #size-cells = <0>;

Same here.

> + local-mac-address = [00 00 00 00 00 00];
> + status = "disabled";
> + };
> +
> + i2c0: i2c@f0014000 {
> + pinctrl-0 = <&pinctrl_i2c0_pu>;
> + status = "okay";
> + };
> +
> + i2c1: i2c@f0018000 {
> + status = "okay";
> +
> + pmic: act8865@5b {
> + compatible = "active-semi,act8865";
> + reg = <0x5b>;
> + status = "disabled";

Why do you keep it disabled?

I may be wrong but on schematic I see only MIC kind of regulators.

> +
> + regulators {
> + vcc_3v3_reg: BUCK_REG1 {
> + regulator-name = "VCC_3V3";
> + regulator-min-microvolt = <3300000>;
> + regulator-max-microvolt = <3300000>;
> + regulator-always-on;
> + };
> +
> + vcc_2v5_reg: LDO_REG2 {
> + regulator-name = "VCC_2V5";
> + regulator-min-microvolt = <2500000>;
> + regulator-max-microvolt = <2500000>;
> + regulator-always-on;
> + };
> +
> + vcc_1v8_reg: LDO_REG3 {
> + regulator-name = "VCC_1V8";
> + regulator-min-microvolt = <1800000>;
> + regulator-max-microvolt = <1800000>;
> + regulator-always-on;
> + };
> +
> + vcc_1v2_reg: BUCK_REG4 {
> + regulator-name = "VCC_1V2";
> + regulator-min-microvolt = <1200000>;
> + regulator-max-microvolt = <1200000>;
> + regulator-always-on;
> + };
> + };
> + };
> + };
> +
> + i2c2: i2c@f801c000 {
> + dmas = <0>, <0>; /* Do not use DMA for i2c2 */

dmas = <0>, <0>; means dma is not used. Comment could be disabled.

> + pinctrl-0 = <&pinctrl_i2c2_pu>;
> + status = "okay";
> + };
> +
> + mmc0: mmc@f0000000 {
> + pinctrl-0 = <&pinctrl_mmc0_clk_cmd_dat0 &pinctrl_mmc0_dat1_3 &pinctrl_mmc0_dat4_7 &pinctrl_mmc0_cd>;
> + vmmc-supply = <&vcc_mmc0_reg>;
> + vqmmc-supply = <&vcc_3v3_reg>;
> + status = "okay";
> + slot@0 {
> + reg = <0>;
> + bus-width = <8>;
> + cd-gpios = <&pioE 0 GPIO_ACTIVE_LOW>;
> + };
> + };
> +
> + dbgu: serial@ffffee00 {
> + status = "okay";
> + };
> +
> + spi0: spi@f0004000 {
> + pinctrl-names = "default", "cs";
> + pinctrl-1 = <&pinctrl_spi0_cs>;
> + cs-gpios = <&pioD 13 0>, <0>, <0>, <&pioD 16 0>;
> + status = "okay";
> + };
> +
> + spi1: spi@f8008000 {
> + pinctrl-names = "default", "cs";
> + pinctrl-1 = <&pinctrl_spi1_cs>;
> + cs-gpios = <&pioC 25 0>, <0>, <0>, <&pioC 28 0>;
> + status = "okay";
> + };
> +
> + tcb0: timer@f0010000 {
> + timer0: timer@0 {
> + compatible = "atmel,tcb-timer";
> + reg = <0>;
> + };
> +
> + timer1: timer@1 {
> + compatible = "atmel,tcb-timer";
> + reg = <1>;
> + };
> + };
> +
> + pinctrl@fffff200 {
> + board {
> + pinctrl_i2c0_pu: i2c0_pu {
> + atmel,pins =
> + <AT91_PIOA 30 AT91_PERIPH_A AT91_PINCTRL_PULL_UP>,
> + <AT91_PIOA 31 AT91_PERIPH_A AT91_PINCTRL_PULL_UP>;
> + };
> +
> + pinctrl_i2c2_pu: i2c2_pu {
> + atmel,pins =
> + <AT91_PIOA 18 AT91_PERIPH_B AT91_PINCTRL_PULL_UP>,
> + <AT91_PIOA 19 AT91_PERIPH_B AT91_PINCTRL_PULL_UP>;
> + };
> +
> + pinctrl_key_gpio: key_gpio_0 {
> + atmel,pins =
> + <AT91_PIOE 29 AT91_PERIPH_GPIO AT91_PINCTRL_PULL_UP_DEGLITCH>;
> + };
> +
> + pinctrl_mmc0_cd: mmc0_cd {
> + atmel,pins =
> + <AT91_PIOE 0 AT91_PERIPH_GPIO AT91_PINCTRL_PULL_UP_DEGLITCH>;
> + };
> +
> + pinctrl_mmc1_cd: mmc1_cd {

This is not used.

> + atmel,pins =
> + <AT91_PIOE 1 AT91_PERIPH_GPIO AT91_PINCTRL_PULL_UP_DEGLITCH>;
> + };
> +
> + pinctrl_spi0_cs: spi0_cs_default {
> + atmel,pins =
> + <AT91_PIOD 13 AT91_PERIPH_GPIO AT91_PINCTRL_NONE
> + AT91_PIOD 16 AT91_PERIPH_GPIO AT91_PINCTRL_NONE>;
> + };
> +
> + pinctrl_spi1_cs: spi1_cs_default {
> + atmel,pins = <AT91_PIOC 25 AT91_PERIPH_GPIO AT91_PINCTRL_NONE
> + AT91_PIOC 28 AT91_PERIPH_GPIO AT91_PINCTRL_NONE>;
> + };
> +
> + pinctrl_usba_vbus: usba_vbus {
> + atmel,pins =
> + <AT91_PIOE 9 AT91_PERIPH_GPIO AT91_PINCTRL_DEGLITCH>; /* PE9, conflicts with A9 */

Is this comment useful? I don't see A9 used by any IP.

> + };
> +
> + pinctrl_usb_default: usb_default {
> + atmel,pins =
> + <AT91_PIOE 3 AT91_PERIPH_GPIO AT91_PINCTRL_NONE
> + AT91_PIOE 4 AT91_PERIPH_GPIO AT91_PINCTRL_NONE>;
> + };
> +
> + pinctrl_vbusfault_irqn: vbusfault_irqn {

This is not used.

> + atmel,pins =
> + <AT91_PIOE 5 AT91_PERIPH_GPIO AT91_PINCTRL_DEGLITCH>;
> + };
> +
> + pinctrl_vcc_mmc0_reg_gpio: vcc_mmc0_reg_gpio_default {

This is not used.

> + atmel,pins = <AT91_PIOE 2 AT91_PERIPH_GPIO AT91_PINCTRL_NONE>;
> + };
> +
> + pinctrl_gpio_leds: gpio_leds_default {

This is not used.

> + atmel,pins =
> + <AT91_PIOE 15 AT91_PERIPH_GPIO AT91_PINCTRL_NONE
> + AT91_PIOE 16 AT91_PERIPH_GPIO AT91_PINCTRL_NONE
> + AT91_PIOE 17 AT91_PERIPH_GPIO AT91_PINCTRL_NONE
> + AT91_PIOE 18 AT91_PERIPH_GPIO AT91_PINCTRL_NONE
> + AT91_PIOE 19 AT91_PERIPH_GPIO AT91_PINCTRL_NONE>;
> + };
> +
> + pinctrl_rgmii_rstn: rgmii_rstn {

This is not used.

> + atmel,pins =
> + <AT91_PIOD 18 AT91_PERIPH_GPIO AT91_PINCTRL_PULL_UP_DEGLITCH>;
> + };
> +
> + pinctrl_spi_irqn: spi_irqn {

This is not used.

> + atmel,pins =
> + <AT91_PIOB 28 AT91_PERIPH_GPIO AT91_PINCTRL_DEGLITCH>;
> + };
> + };
> + };
> + };
> +
> + usb0: gadget@500000 {
> + atmel,vbus-gpio = <&pioE 9 GPIO_ACTIVE_HIGH>; /* PE9, conflicts with A9 */

Same here regarding comments.

> + pinctrl-names = "default";
> + pinctrl-0 = <&pinctrl_usba_vbus>;
> + status = "okay";
> + };
> +
> + usb1: ohci@600000 {
> + num-ports = <3>;
> + atmel,vbus-gpio = <0
> + &pioE 3 GPIO_ACTIVE_HIGH
> + &pioE 4 GPIO_ACTIVE_HIGH
> + >;
> + pinctrl-names = "default";
> + pinctrl-0 = <&pinctrl_usb_default>;
> + status = "okay";
> + };
> +
> + usb2: ehci@700000 {
> + status = "okay";
> + };
> +
> + ebi: ebi@10000000 {
> + pinctrl-0 = <&pinctrl_ebi_nand_addr>;
> + pinctrl-names = "default";
> + status = "okay";
> +
> + nand_controller: nand-controller {
> + status = "okay";
> +
> + nand@3 {
> + reg = <0x3 0x0 0x2>;
> + atmel,rb = <0>;
> + nand-bus-width = <8>;
> + nand-ecc-mode = "hw";
> + nand-ecc-strength = <4>;
> + nand-ecc-step-size = <512>;
> + nand-on-flash-bbt;
> + label = "atmel_nand";
> +
> + partitions {
> + compatible = "fixed-partitions";
> + #address-cells = <1>;
> + #size-cells = <1>;
> +
> + at91bootstrap@0 {
> + label = "at91bootstrap";
> + reg = <0x0 0x40000>;
> + };
> +
> + bootloader@40000 {
> + label = "bootloader";
> + reg = <0x40000 0xc0000>;
> + };
> +
> + bootloaderenvred@100000 {
> + label = "bootloader env redundant";
> + reg = <0x100000 0x40000>;
> + };
> +
> + bootloaderenv@140000 {
> + label = "bootloader env";
> + reg = <0x140000 0x40000>;
> + };
> +
> + dtb@180000 {
> + label = "device tree";
> + reg = <0x180000 0x80000>;
> + };
> +
> + kernel@200000 {
> + label = "kernel";
> + reg = <0x200000 0x600000>;
> + };
> +
> + rootfs@800000 {
> + label = "rootfs";
> + reg = <0x800000 0x0f800000>;
> + };
> + };
> + };
> + };
> + };
> + };
> +
> + vcc_mmc0_reg: fixedregulator_mmc0 {
> + compatible = "regulator-fixed";
> + gpio = <&pioE 2 GPIO_ACTIVE_LOW>;
> + regulator-name = "mmc0-card-supply";
> + regulator-min-microvolt = <3300000>;
> + regulator-max-microvolt = <3300000>;
> + regulator-always-on;
> + };
> +
> + gpio_keys {
> + compatible = "gpio-keys";
> +
> + pinctrl-names = "default";
> + pinctrl-0 = <&pinctrl_key_gpio>;
> +
> + button3 {

button-<index>

> + label = "PB_USER";
> + gpios = <&pioE 29 GPIO_ACTIVE_LOW>;
> + linux,code = <0x104>;
> + wakeup-source;
> + };
> + };
> +
> + leds {
> + compatible = "gpio-leds";

Use pinctrl-names, pinctrl-default for this one. With the pin controller on
SAMA5D3 the might happen that not all leds are working correclty for you.

> +
> + pe15 {
> + label = "pe15";
> + gpios = <&pioE 15 GPIO_ACTIVE_LOW>;
> + };
> +
> + pe16 {
> + label = "pe16";
> + gpios = <&pioE 16 GPIO_ACTIVE_LOW>;
> + };
> +
> + pe17 {
> + label = "pe17";
> + gpios = <&pioE 17 GPIO_ACTIVE_LOW>;
> + };
> +
> + pe18 {
> + label = "pe18";
> + gpios = <&pioE 18 GPIO_ACTIVE_LOW>;
> + };
> +
> + pe19 {
> + label = "pe19";
> + gpios = <&pioE 19 GPIO_ACTIVE_LOW>;
> + };

On documentation (FIGURE B-6: SAMA5D3 SCHEMATICS - SOC GPIO AND MISC
HEADERS at [1]) pe15..pe19 are not connected to any leds.

[1]
https://ww1.microchip.com/downloads/en/DeviceDoc/SAMA5D3-Ethernet-Development-System-Users-Guide-50002789A.pdf

> + };
> +};
> --
> 2.17.1
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@xxxxxxxxxxxxxxxxxxx
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Next message: Daniel Bristot de Oliveira: "Re: [PATCH v2] rtla: Define syscall numbers for riscv"
Previous message: Andy Shevchenko: "[PATCH v1 1/1] asm-generic: Make parameter types consisten in _unaligned_be48()"
In reply to: Jerry Ray: "[linux][PATCH v1 1/1] dts: arm: at91: Add SAMA5D3-EDS Board"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]