Re: [PATCH] watchdog: armada_37xx_wdt: Fix .set_timeout callback

From: Marek Behún
Date: Tue Jul 26 2022 - 09:46:12 EST


On Tue, 26 Jul 2022 10:56:12 +0200
Pali Rohár <pali@xxxxxxxxxx> wrote:

> ioctl(WDIOC_SETTIMEOUT) calls .set_timeout and .ping callbacks and it is
> expected that it changes current watchdog timeout.
>
> armada_37xx_wdt's .ping callback just reping counter 0 and does not touch
> counter 1 used for timeout. So it is needed to set counter 1 to the new
> value in .set_timeout callback to ensure ioctl(WDIOC_SETTIMEOUT)
> functionality. Fix it.
>
> Fixes: 54e3d9b518c8 ("watchdog: Add support for Armada 37xx CPU watchdog")
> Signed-off-by: Pali Rohár <pali@xxxxxxxxxx>

Reviewed-by: Marek Behún <kabel@xxxxxxxxxx>