Re: [PATCH v6 04/17] arm64: stacktrace: Handle frame pointer from different address spaces

[Kalesh Singh]

On Tue, Jul 26, 2022 at 7:34 AM Mark Brown <broonie@xxxxxxxxxx> wrote:
>
> On Tue, Jul 26, 2022 at 12:37:37AM -0700, Kalesh Singh wrote:
> > The unwinder code is made reusable so that it can be used to
> > unwind various types of stacks. One usecase is unwinding the
> > nVHE hyp stack from the host (EL1) in non-protected mode. This
> > means that the unwinder must be able to translate HYP stack
> > addresses to kernel addresses.
> >
> > Add a callback (stack_trace_translate_fp_fn) to allow specifying
> > the translation function.
>
> Reviewed-by: Mark Brown <broonie@xxxxxxxxxx>
>
> with or without one very minor thing:
>
> >  static inline int unwind_next_common(struct unwind_state *state,
> > -                                  struct stack_info *info)
> > +                                  struct stack_info *info,
> > +                                  stack_trace_translate_fp_fn translate_fp)
> >  {
> > +     unsigned long fp = state->fp, kern_fp = fp;
>
> As a coding style nit I don't love having multiple assignments on a
> single line especially as part of declarations.

Hi Mark,

Thanks for the reviews. I'll update this if a respin is needed.

--Kalesh