Re: [PATCH V6 0/2] Add ums512 clocks and relative bindings file

From: Krzysztof Kozlowski
Date: Tue Jul 26 2022 - 13:47:24 EST


On 26/07/2022 12:24, Cixi Geng wrote:
> From: Cixi Geng <cixi.geng1@xxxxxxxxxx>
>
> This patchset is add the UMS512 clocks support
>
> v2 changes:
> adjust description and add the "sprd,ums512-glbregs,syscon,simple-mfd"
> compatibles to fix match failed logs in the dt_binding_check.
> add the property license and copyright notice.
>
> v3 changes:
> fix wrong indentation and hint: "maxItems" is not needed with an "items"
> list when use the latest dtschema.
>
> v4 changes:
> move the syscon bindins from clk to glbreg yaml file by pickup
> chunyan's patch for global registers bindings
> fix the comments from Krzysztof in v3 patchset
> add the Acked-by: Krzysztof in patch v4 3/4
> fix the warning Prefer "GPL" over "GPL v2"
>
> v5 changes:
> Add review tags.
> fix the comments in ums512-glbreg.yaml.
>
> v6 changes:
> No more send the patch 1/4 and 3/4 in V5 for applied by Stephen
> change GPL to GPL v2 license
> fix the lack of space in some "{" and "}"
> add check error for sprd_clk_regmap_init.

That's not good. That was a dependency here (for MFD bindings). You must
describe the dependencies in cover letter so maintainers know how to do it.

Your MFD patch is not applicable now...


Best regards,
Krzysztof