Re: [PATCH -next] x86/cyrix: include header linux/isa-dma.h
From: Bjorn Helgaas
Date: Tue Jul 26 2022 - 15:05:02 EST
On Mon, Jul 25, 2022 at 01:22:24PM -0700, Randy Dunlap wrote:
> x86/kernel/cpu/cyrix.c now needs to include <linux/isa-dma.h>
> since the 'isa_dma_bridge_buggy' variable was moved to it.
>
> Fixes this build error:
>
> ../arch/x86/kernel/cpu/cyrix.c: In function ‘init_cyrix’:
> ../arch/x86/kernel/cpu/cyrix.c:277:17: error: ‘isa_dma_bridge_buggy’ undeclared (first use in this function)
> 277 | isa_dma_bridge_buggy = 2;
>
> Fixes: abb4970ac335 ("PCI: Move isa_dma_bridge_buggy out of asm/dma.h")
> Signed-off-by: Randy Dunlap <rdunlap@xxxxxxxxxxxxx>
I appended this to my pci/header-cleanup-immutable branch for v5.20,
thanks!
> Cc: Stafford Horne <shorne@xxxxxxxxx>
> Cc: Bjorn Helgaas <bhelgaas@xxxxxxxxxx>
> Cc: Borislav Petkov <bp@xxxxxxxxx>
> Cc: Dave Hansen <dave.hansen@xxxxxxxxxxxxxxx>
> Cc: x86@xxxxxxxxxx
> ---
> arch/x86/kernel/cpu/cyrix.c | 1 +
> 1 file changed, 1 insertion(+)
>
> --- a/arch/x86/kernel/cpu/cyrix.c
> +++ b/arch/x86/kernel/cpu/cyrix.c
> @@ -1,6 +1,7 @@
> // SPDX-License-Identifier: GPL-2.0
> #include <linux/bitops.h>
> #include <linux/delay.h>
> +#include <linux/isa-dma.h>
> #include <linux/pci.h>
> #include <asm/dma.h>
> #include <linux/io.h>