Re: [PATCH 1/2] scsi: ufs: Add Multi-Circular Queue support

From: Bart Van Assche
Date: Tue Jul 26 2022 - 18:47:59 EST


On 7/25/22 09:35, Asutosh Das (asd) wrote:
On 7/23/2022 2:23 PM, Avri Altman wrote:
Also maybe we can constify sizeof(struct utp_transfer_req_desc) which is used now few times.

Ok, agree to make sizeof(struct utp_transfer_req_desc) a constant in the next version.

Please don't. I'm concerned that introducing a symbolic name for that sizeof() expression will make code harder to read instead of easier.

Thanks,

Bart.