Re: [PATCH] staging: rtl8723bs: remove useless comparison in _rtw_reg_apply_flags()
From: Greg Kroah-Hartman
Date: Wed Jul 27 2022 - 02:41:09 EST
On Tue, Jul 19, 2022 at 06:53:09PM +0300, Andrey Strachuk wrote:
> Local variable 'ch' is initialized by an address
> of field of ieee80211_supported_band structure, so it does
> not make sense to compare 'ch' with NULL.
Where is it initialized with an address? You need to document this
here.
>
> Found by Linux Verification Center (linuxtesting.org) with SVACE.
>
> Signed-off-by: Andrey Strachuk <strochuk@xxxxxxxxx>
> Fixes: 554c0a3abf21 ("staging: Add rtl8723bs sdio wifi driver")
This is not a bug fix, but a code optimization, so no need for this
Fixes: tag.
thanks,
greg k-h