Re: [PATCH v3] memblock tests: compiling error

[Mike Rapoport]

Hi,

On Wed, Jul 27, 2022 at 10:39:45AM +0800, Liu Xinpeng wrote:
> Subject: [PATCH v3] memblock tests: compiling error

"fix compilation errors" looks better, don't you think?

Another thing, is when you post vN of a patch please add a "patch
changelog" that describes the changes to the previous version.

I'd suggest to take a look at sections "Respond to review comments" and
"Don't get discouraged - or impatient" of the submitting patches guide.

https://kernel.org/doc/html/latest/process/submitting-patches.html

> memblock.o: In function `memblock_find_in_range.constprop.9':
> memblock.c:(.text+0x4651): undefined reference to `pr_warn_ratelimited'
> memblock.o: In function `memblock_mark_mirror':
> memblock.c:(.text+0x7171): undefined reference to `mirrored_kernelcore'

As people pointed in v1 thread, the description on how to reproduce this is
missing.
 
> Fixes: 902c2d91582c ("memblock: Disable mirror feature if kernelcore is not specified")
> Fixes: 14d9a675fd0d ("mm: Ratelimited mirrored memory related warning messages")
> 
> Signed-off-by: Liu Xinpeng <liuxp11@xxxxxxxxxxxxxxx>
> Tested-by: Ma Wupeng <mawupeng1@xxxxxxxxxx>
> ---
>  tools/testing/memblock/internal.h | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/tools/testing/memblock/internal.h b/tools/testing/memblock/internal.h
> index c2a492c05e0c..fdb7f5db7308 100644
> --- a/tools/testing/memblock/internal.h
> +++ b/tools/testing/memblock/internal.h
> @@ -9,6 +9,10 @@
>  static int memblock_debug = 1;
>  #endif
>  
> +#define pr_warn_ratelimited(fmt, ...)    printf(fmt, ##__VA_ARGS__)
> +
> +bool mirrored_kernelcore = false;
> +
>  struct page {};
>  
>  void memblock_free_pages(struct page *page, unsigned long pfn,
> -- 
> 1.8.3.1
> 

-- 
Sincerely yours,
Mike.