Re: [PATCH v2 1/1] iio: humidity: hdc100x: add manufacturer and device ID cehck

[Andy Shevchenko]

On Wed, Jul 27, 2022 at 8:46 AM Potin Lai <potin.lai.pt@xxxxxxxxx> wrote:
>
> Add manufacturer and device ID checking during probe, and skip the
> checking if chip model not supported.
>
> Supported:
> - HDC1000
> - HDC1010
> - HDC1050
> - HDC1080
>
> Not supported:
> - HDC1008

Thanks for an update, my comments below.

...

> +       const struct of_device_id *match;

Don't you have a compiler warning? Always compile your code with `make W=1`

...

> +       data = device_get_match_data(&client->dev);

> +       if (data) {

This check is redundant. Too much protective programming. Just oblige
that matched ID has to always have an associated data.

> +               if (!data->support_mfr_check)
> +                       return true;
> +       }

...

> -       .probe = hdc100x_probe,
> +       .probe_new = hdc100x_probe,

Make this a separate patch before the presented one.

-- 
With Best Regards,
Andy Shevchenko