Re: [PATCH 1/2] dt-bindings: arm: qcom: document zoglin board

From: Doug Anderson
Date: Wed Jul 27 2022 - 09:46:13 EST


Hi,

On Tue, Jul 26, 2022 at 9:24 PM Bob Moragues <moragues@xxxxxxxxxxxx> wrote:
>
> Zoglin is a Hoglin Chromebook with SPI Flash reduced from 64MB to 8MB.
> Zoglin is identical to Hoglin except for the SPI Flash.
> The actual SPI Flash is dynamically probed at and not specified in DTS.
>
> Signed-off-by: Bob Moragues <moragues@xxxxxxxxxxxx>
>
> Signed-off-by: Bob Moragues <moragues@xxxxxxxxxx>

You need to figure out how to get your system not to add the extra
"@google.com" Signed-off-by. It's probably worth spinning a v2 with
that, if for no other reason than to debug your setup for the next
patch you send.

Other than that, this looks right to me.

Reviewed-by: Douglas Anderson <dianders@xxxxxxxxxxxx>

(you should carry my Reviewed-by tag forward on your v2 unless you
change anything significant)