Re: [PATCH 1/3] staging: vt6655: Rename byOrgValue to reg_value in a macro

[Greg Kroah-Hartman]

On Wed, Jul 27, 2022 at 05:54:04PM +0200, Philipp Hortmann wrote:
> On 7/27/22 08:47, Greg Kroah-Hartman wrote:
> > On Wed, Jul 20, 2022 at 06:24:32PM +0200, Philipp Hortmann wrote:
> > > Fix name of a variable in a macro that uses CamelCase which is not
> > > accepted by checkpatch.pl
> > 
> > Why rename something you are about to delete in a later patch?
> > 
> > thanks,
> > 
> > greg k-h
> 
> I need to rename this variable. Does it matter if I do it in first or last
> patch? When doing it first I do not have to review so much checkpatch
> warnings.
> 
> Or is it OK to convert the macro to a function and rename the variable in
> one patch?

Convert and rename at the same time, that makes it easier and simpler
overall.

thanks,

greg k-h