Re: [PATCH RESEND v6 6/8] blk-throttle: calling throtl_dequeue/enqueue_tg in pairs

From: Tejun Heo
Date: Wed Jul 27 2022 - 15:07:41 EST


On Fri, Jul 01, 2022 at 05:34:39PM +0800, Yu Kuai wrote:
> From: Yu Kuai <yukuai3@xxxxxxxxxx>
>
> It's a litter weird to call throtl_dequeue_tg() unconditionally in
^
little

> throtl_select_dispatch(), since it will be called in
> tg_update_disptime() again if some bio is still throttled.
>
> Signed-off-by: Yu Kuai <yukuai3@xxxxxxxxxx>

Maybe note that this doesn't create any functional differences in the
description?

Acked-by: Tejun Heo <tj@xxxxxxxxxx>

Thanks.

--
tejun