Re: [PATCH 5.15 040/201] sysctl: move some boundary constants from sysctl.c to sysctl_vals

[Sasha Levin]

On Wed, Jul 27, 2022 at 08:11:03PM +0200, Greg Kroah-Hartman wrote:
> On Wed, Jul 27, 2022 at 10:31:37AM -0700, Luis Chamberlain wrote:
> > On Wed, Jul 27, 2022 at 06:09:04PM +0200, Greg Kroah-Hartman wrote:
> > > From: Xiaoming Ni <nixiaoming@xxxxxxxxxx>
> > >
> > > [ Upstream commit 78e36f3b0dae586f623c4a37ec5eb5496f5abbe1 ]
> > >
> > > sysctl has helpers which let us specify boundary values for a min or max
> > > int value.  Since these are used for a boundary check only they don't
> > > change, so move these variables to sysctl_vals to avoid adding duplicate
> > > variables.  This will help with our cleanup of kernel/sysctl.c.
> > >
> > > [akpm@xxxxxxxxxxxxxxxxxxxx: update it for "mm/pagealloc: sysctl: change watermark_scale_factor max limit to 30%"]
> > > [mcgrof@xxxxxxxxxx: major rebase]
> > >
> > > Link: https://lkml.kernel.org/r/20211123202347.818157-3-mcgrof@xxxxxxxxxx
> > > Signed-off-by: Xiaoming Ni <nixiaoming@xxxxxxxxxx>
> > > Signed-off-by: Luis Chamberlain <mcgrof@xxxxxxxxxx>
> > > Reviewed-by: Kees Cook <keescook@xxxxxxxxxxxx>
> > > Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>
> > > Signed-off-by: Linus Torvalds <torvalds@xxxxxxxxxxxxxxxxxxxx>
> > > Signed-off-by: Sasha Levin <sashal@xxxxxxxxxx>
> >
> > I'm a bit puzzled. How / why is this a stable fix?
>
> I think it's needed by a patch later in the series.  Sasha, can you
> verify?

Yes, about 30 patches in this series need this patch.

--
Thanks,
Sasha