Re: [PATCH v3 1/2] dt-bindings: display: panel: Add Novatek NT35596S panel bindings

[Molly Sophia]

Thanks! I'll handle that and send the new patches later.

Best regards,
Molly

On Wed, Jul 27, 2022 at 6:24 PM Krzysztof Kozlowski
<krzysztof.kozlowski@xxxxxxxxxx> wrote:
>
> On 26/07/2022 12:15, Molly Sophia wrote:
> > Add documentation for "novatek,nt35596s" panel.
> >
> > Changes in v3:
> > - Embed the documentation into existing one (novatek,nt36672a).
> >
> > Signed-off-by: Molly Sophia <mollysophia379@xxxxxxxxx>
> > ---
> >  .../display/panel/novatek,nt36672a.yaml       | 20 ++++++++++++-------
> >  1 file changed, 13 insertions(+), 7 deletions(-)
> >
> > diff --git a/Documentation/devicetree/bindings/display/panel/novatek,nt36672a.yaml b/Documentation/devicetree/bindings/display/panel/novatek,nt36672a.yaml
> > index 563766d283f6..560fb66d0e5a 100644
> > --- a/Documentation/devicetree/bindings/display/panel/novatek,nt36672a.yaml
> > +++ b/Documentation/devicetree/bindings/display/panel/novatek,nt36672a.yaml
> > @@ -20,14 +20,20 @@ allOf:
> >
> >  properties:
> >    compatible:
> > -    items:
> > -      - enum:
> > -          - tianma,fhd-video
> > -      - const: novatek,nt36672a
> > +    oneOf:
> > +      - items:
> > +          - enum:
> > +              - tianma,fhd-video
> > +          - const: novatek,nt36672a
> > +
> > +      - items:
> > +          - enum:
> > +              - jdi,fhd-nt35596s
> > +          - const: novatek,nt35596s
>
> This entire entry should be rather before nt36672a judging by numbers:
>
> +    oneOf:
> +      - items:
> +          - enum:
> +              - jdi,fhd-nt35596s
> +          - const: novatek,nt35596s
> +
> +      - items:
> +          - enum:
> +              - tianma,fhd-video
> +          - const: novatek,nt36672a
>
>
> Best regards,
> Krzysztof