RE: [PATCH 2/7] tty: xilinx_uartps: Check the clk_enable return value

[Datta, Shubhrajyoti]

[AMD Official Use Only - General]

Hi Greg,

> -----Original Message-----
> From: Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx>
> Sent: Friday, May 6, 2022 2:20 AM
> To: Shubhrajyoti Datta <shubhrajyoti.datta@xxxxxxxxxx>
> Cc: linux-serial@xxxxxxxxxxxxxxx; michal.simek@xxxxxxxxxx;
> jirislaby@xxxxxxxxxx; git@xxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx
> Subject: Re: [PATCH 2/7] tty: xilinx_uartps: Check the clk_enable return value
> 
> On Fri, Apr 29, 2022 at 01:44:17PM +0530, Shubhrajyoti Datta wrote:
> > Check the clk_enable return value.
> 
> That says what, but not why.
> 
Will fix v2.
> >
> > Addresses-Coverity: Event check_return.
> 
> Shouldn't this be a covertity id?

I could not find the warning in the Coverity that is run on the linux kernel. 
Somehow was seeing int when I was running  locally.

> 
> thanks,
> 
> greg k-h