Re: [PATCH v8 00/11] support non power of 2 zoned device
From: Pankaj Raghav
Date: Thu Jul 28 2022 - 07:58:18 EST
Hi Bart,
On 2022-07-28 01:19, Bart Van Assche wrote:
> On 7/27/22 09:22, Pankaj Raghav wrote:
>> This series adds support to npo2 zoned devices in the block and nvme
>> layer and a new **dm target** is added: dm-po2z-target. This new
>> target will be initially used for filesystems such as btrfs and
>> f2fs that does not have native npo2 zone support.
>
> Should any SCSI changes be included in this patch series? From sd_zbc.c:
>
> if (!is_power_of_2(zone_blocks)) {
> sd_printk(KERN_ERR, sdkp,
> "Zone size %llu is not a power of two.\n",
> zone_blocks);
> return -EINVAL;
> }
>
I would keep these changes out of the current patch series because it
will also increase the test scope. I think once the block layer
constraint is removed as a part of this series, we can work on the SCSI
changes in the next cycle.
> Thanks,
>
> Bart.