Re: [PATCH v10 1/8] mm/demotion: Add support for explicit memory tiers
From: Johannes Weiner
Date: Thu Jul 28 2022 - 13:23:18 EST
On Wed, Jul 27, 2022 at 09:16:08AM +0800, Huang, Ying wrote:
> Aneesh Kumar K V <aneesh.kumar@xxxxxxxxxxxxx> writes:
> > It is an abstract concept that indicates the performance of the
> > device. As we learn more about which device attribute makes more impact in
> > defining hierarchy, performance level will give more weightage to that specific
> > attribute. It could be write latency or bandwidth. For me, distance has a direct
> > linkage to latency because that is how we define numa distance now. Adding
> > abstract to the name is not making it more abstract than perf_level.
> >
> > I am open to suggestions from others. Wei Xu has also suggested perf_level name.
> > I can rename this to abstract_distance if that indicates the goal better.
>
> I'm open to naming. But I think that it's good to define it at some
> degree instead of completely opaque stuff. If it's latency based, then
> low value corresponds to high performance. If it's bandwidth based,
> then low value corresponds to low performance.
>
> Hi, Wei and Johannes,
>
> What do you think about this?
I'm also partial to distance. It's a familiar metric in non-uniform
memory for guiding placement decisions, and that is how we continue to
use it here too.
It's historically meant bus latency, but given how the kernel
perceives and acts on the metric IMO the term works just fine to
express differences in bandwidth and chip resonpse times as well.