Re: [PATCH] nouveau/svm: Fix to migrate all requested pages

From: Ralph Campbell
Date: Thu Jul 28 2022 - 15:28:03 EST


On 7/19/22 23:27, Alistair Popple wrote:

Users may request that pages from an OpenCL SVM allocation be migrated
to the GPU with clEnqueueSVMMigrateMem(). In Nouveau this will call into
nouveau_dmem_migrate_vma() to do the migration. If the total range to be
migrated exceeds SG_MAX_SINGLE_ALLOC the pages will be migrated in
chunks of size SG_MAX_SINGLE_ALLOC. However a typo in updating the
starting address means that only the first chunk will get migrated.

Fix the calculation so that the entire range will get migrated if
possible.

Signed-off-by: Alistair Popple <apopple@xxxxxxxxxx>
Fixes: e3d8b0890469 ("drm/nouveau/svm: map pages after migration")

Thanks for fixing this!
Reviewed-by: Ralph Campbell <rcampbell@xxxxxxxxxx>