Re: [PATCH] sched/net/act: Remove temporary state variables

From: Jakub Kicinski
Date: Thu Jul 28 2022 - 23:16:09 EST


On Wed, 27 Jul 2022 17:41:46 +0800 Li zeming wrote:
> The temporary variable ret could be removed and the corresponding state
> can be directly returned.

How many case like this are there in the kernel?
What tool are you using to find this?
We should focus on creating CI tools which can help catch instances of
this pattern in new code before it gets added, rather than cleaning up
old code. It just makes backports harder for hardly any gain.