Re: [PATCH v6 12/13] leds: flash: mt6370: Add MediaTek MT6370 flashlight support

From: szuni chen
Date: Fri Jul 29 2022 - 02:17:29 EST


Andy Shevchenko <andy.shevchenko@xxxxxxxxx> 於 2022年7月25日 週一 下午4:51寫道:
>
> On Fri, Jul 22, 2022 at 12:25 PM ChiaEn Wu <peterwu.pub@xxxxxxxxx> wrote:
> >
> > From: Alice Chen <alice_chen@xxxxxxxxxxx>
> >
> > The MediaTek MT6370 is a highly-integrated smart power management IC,
> > which includes a single cell Li-Ion/Li-Polymer switching battery
> > charger, a USB Type-C & Power Delivery (PD) controller, dual Flash
> > LED current sources, a RGB LED driver, a backlight WLED driver,
> > a display bias driver and a general LDO for portable devices.
> >
> > The Flash LED in MT6370 has 2 channels and support torch/strobe mode.
> > Add the support of MT6370 FLASH LED.
> >
> > Signed-off-by: Alice Chen <alice_chen@xxxxxxxxxxx>
>
> This SoB chain is wrong. Prioritize and read Submitting Patches!
>
Hi Andy,

After reading the Submitted Patches,
ChiaEn Wu wasn't involved in the development but he submitted the patch,
So, ChiaEn Wu <chiaen_wu@xxxxxxxxxxx> should be the last SoB, right?
I will revise SoB to

Signed-off-by: SzuNi Chen <alice_chen@xxxxxxxxxxx>
Signed-off-by: ChiaEn Wu <chiaen_wu@xxxxxxxxxxx>

If there is anything else I need to fix, please let me know. Thank you.


Best Regards,
Szuni Chen