Re: [PATCH 0/4] add support for another simatic board
From: Henning Schild
Date: Fri Jul 29 2022 - 03:07:29 EST
I wanted to send this series to a wider audience, somehow i messed that
up and might have to send again. Maybe the v5, and if there is no
changes i might send again as v4.
Henning
Am Thu, 28 Jul 2022 17:56:48 +0200
schrieb Henning Schild <henning.schild@xxxxxxxxxxx>:
> This series first enables a SuperIO GPIO driver to support a chip from
> the vendor Nuvoton, the driver is for Fintek devices but those just
> are very similar. And in watchdog and hwmon subsystems these SuperIO
> drivers also share code and are sometimes called a family.
>
> In another step the individual banks receive a label to tell them
> apart, a step which potentially changes an interface to legacy users
> that might rely on all banks having the same label, or an exact
> label. But since a later patch wants to use GPIO_LOOKUP unique labels
> are needed and i decided to assign them for all supported chips.
>
> In a following patch the Simatic GPIO LED driver is extended to
> provide LEDs in case that SuperIO GPIO driver can be loaded.
>
> Last but not least the watchdog module of that same SuperIO gets
> loaded on a best effort basis.
>
> Note similar patches have appreared before as
> "[PATCH v3 0/1] add device driver for Nuvoton SIO gpio function"
> The main difference here is that i added chip support to an existing
> driver instead of creating a new one. And that i actually propose all
> patches and do not just have the LED patch for Simatic as an example.
> Also note that the patches are based on
> "[PATCH v6 00/12] platform/x86: introduce p2sb_bar() helper"
>
> Henning Schild (4):
> gpio-f7188x: Add GPIO support for Nuvoton NCT6116
> gpio-f7188x: use unique labels for banks/chips
> leds: simatic-ipc-leds-gpio: add new model 227G
> platform/x86: simatic-ipc: enable watchdog for 227G
>
> drivers/gpio/gpio-f7188x.c | 192
> +++++++++++------- drivers/leds/simple/simatic-ipc-leds-gpio.c |
> 42 +++- drivers/platform/x86/simatic-ipc.c | 7 +-
> .../platform_data/x86/simatic-ipc-base.h | 1 +
> include/linux/platform_data/x86/simatic-ipc.h | 1 +
> 5 files changed, 158 insertions(+), 85 deletions(-)
>