Re: [PATCH] staging: vme_user: Put quoted string in a single line

[Greg KH]

On Fri, Jul 29, 2022 at 04:48:06PM +0800, Mingyi Kang wrote:
> This patch resolves the follwing checkpatch warnings:
> 
> WARNING: quoted string split across lines
> +			dev_err(tsi148_bridge->parent, "VME Mailbox %d received"
> +				": 0x%x\n", i, val);
> 
> WARNING: quoted string split across lines
> +	dev_err(tsi148_bridge->parent, "PCI Exception at address: 0x%08x:%08x, "
> +		"attributes: %08x\n",
> 
> WARNING: quoted string split across lines
> +	dev_err(tsi148_bridge->parent, "PCI-X attribute reg: %08x, PCI-X split "
> +		"completion reg: %08x\n",
> 
> WARNING: quoted string split across lines
> +		dev_err(tsi148_bridge->parent, "VME Bus Exception Overflow "
> +			"Occurred\n");
> 
> WARNING: quoted string split across lines
> +		dev_err(tsi148_bridge->parent, "Can't get assigned pci irq "
> +			"vector %02X\n", pdev->irq);
> 
> WARNING: quoted string split across lines
> +		dev_err(tsi148_bridge->parent, "Failed to allocate mem "
> +			"resource for window %d size 0x%lx start 0x%lx\n",
> 
> WARNING: quoted string split across lines
> +		dev_err(tsi148_bridge->parent, "Invalid VME Window "
> +			"alignment\n");
> WARNING: quoted string split across lines
> +		dev_err(tsi148_bridge->parent, "Size must be non-zero for "
> +			"enabled windows\n");
> 
> WARNING: quoted string split across lines
> +		dev_err(tsi148_bridge->parent, "Unable to allocate memory for "
> +			"resource\n");
> 
> WARNING: quoted string split across lines
> +		dev_err(tsi148_bridge->parent, "Invalid VME Offset "
> +			"alignment\n");
> 
> WARNING: quoted string split across lines
> +		dev_warn(tsi148_bridge->parent, "Currently not setting "
> +			"Broadcast Select Registers\n");
> 
> WARNING: quoted string split across lines
> +		dev_err(dev, "Currently not setting Broadcast Select "
> +			"Registers\n");
> 
> WARNING: quoted string split across lines
> +		dev_err(dev, "Currently not setting Broadcast Select "
> +			"Registers\n");
> 
> WARNING: quoted string split across lines
> +		dev_err(tsi148_bridge->parent, "Descriptor not aligned to 8 "
> +			"byte boundary as required: %p\n",
> 
> warning: quoted string split across lines
> +			dev_err(tsi148_bridge->parent, "location monitor "
> +				"callback attached, can't reset\n");
> 
> WARNING: quoted string split across lines
> +		dev_err(tsi148_bridge->parent, "Location monitor not properly "
> +			"configured\n");
> 
> WARNING: quoted string split across lines
> +		dev_err(tsi148_bridge->parent, "Failed to allocate memory for "
> +			"CR/CSR image\n");
> 
> WARNING: quoted string split across lines
> +			dev_err(tsi148_bridge->parent, "Configuring flush image"
> +				" failed\n");
> 
> Signed-off-by: Mingyi Kang <jerrykang026@xxxxxxxxx>
> ---
>  drivers/staging/vme_user/vme_tsi148.c | 57 +++++++++------------------
>  1 file changed, 19 insertions(+), 38 deletions(-)
> 
> diff --git a/drivers/staging/vme_user/vme_tsi148.c b/drivers/staging/vme_user/vme_tsi148.c
> index 956476213241..40bb432861c8 100644
> --- a/drivers/staging/vme_user/vme_tsi148.c
> +++ b/drivers/staging/vme_user/vme_tsi148.c
> @@ -125,8 +125,7 @@ static u32 tsi148_MB_irqhandler(struct vme_bridge *tsi148_bridge, u32 stat)
>  	for (i = 0; i < 4; i++) {
>  		if (stat & TSI148_LCSR_INTS_MBS[i]) {
>  			val = ioread32be(bridge->base +	TSI148_GCSR_MBOX[i]);
> -			dev_err(tsi148_bridge->parent, "VME Mailbox %d received"
> -				": 0x%x\n", i, val);
> +			dev_err(tsi148_bridge->parent, "VME Mailbox %d received: 0x%x\n", i, val);

Unwrapping the string is fine, but not the arguments.  Did you run
checkpatch on this change?  I see some warnings on it, please don't
introduce new ones.

thanks,

greg k-h