RE: [PATCH v4 00/25] net: dpaa: Cleanups in preparation for phylink conversion

[Camelia Alexandra Groza]

> -----Original Message-----
> From: Sean Anderson <sean.anderson@xxxxxxxx>
> Sent: Monday, July 25, 2022 18:10
> To: David S . Miller <davem@xxxxxxxxxxxxx>; Eric Dumazet
> <edumazet@xxxxxxxxxx>; Jakub Kicinski <kuba@xxxxxxxxxx>; Paolo Abeni
> <pabeni@xxxxxxxxxx>; netdev@xxxxxxxxxxxxxxx
> Cc: linuxppc-dev@xxxxxxxxxxxxxxxx; Camelia Alexandra Groza
> <camelia.groza@xxxxxxx>; open list <linux-kernel@xxxxxxxxxxxxxxx>;
> Madalin Bucur <madalin.bucur@xxxxxxx>; linux-arm-
> kernel@xxxxxxxxxxxxxxxxxxx; Sean Anderson <sean.anderson@xxxxxxxx>;
> Krzysztof Kozlowski <krzysztof.kozlowski+dt@xxxxxxxxxx>; Leo Li
> <leoyang.li@xxxxxxx>; Rob Herring <robh+dt@xxxxxxxxxx>;
> devicetree@xxxxxxxxxxxxxxx
> Subject: [PATCH v4 00/25] net: dpaa: Cleanups in preparation for phylink
> conversion
> 
> This series contains several cleanup patches for dpaa/fman. While they
> are intended to prepare for a phylink conversion, they stand on their
> own. This series was originally submitted as part of [1].
> 
> [1] https://lore.kernel.org/netdev/20220715215954.1449214-1-sean.anderson@xxxxxxxx 

For the series:
Acked-by: Camelia Groza <camelia.groza@xxxxxxx>
 
> Changes in v4:
> - Clarify commit message
> - weer -> were
> - tricy -> tricky
> - Use mac_dev for calling change_addr
> - qman_cgr_create -> qman_create_cgr
> 
> Changes in v3:
> - Incorperate some minor changes into the first FMan binding commit
> 
> Changes in v2:
> - Convert FMan MAC bindings to yaml
> - Remove some unused variables
> - Fix prototype for dtsec_initialization
> - Fix warning if sizeof(void *) != sizeof(resource_size_t)
> - Specify type of mac_dev for exception_cb
> - Add helper for sanity checking cgr ops
> - Add CGR update function
> - Adjust queue depth on rate change
> 
> Sean Anderson (25):
>   dt-bindings: net: Convert FMan MAC bindings to yaml
>   net: fman: Convert to SPDX identifiers
>   net: fman: Don't pass comm_mode to enable/disable
>   net: fman: Store en/disable in mac_device instead of mac_priv_s
>   net: fman: dtsec: Always gracefully stop/start
>   net: fman: Get PCS node in per-mac init
>   net: fman: Store initialization function in match data
>   net: fman: Move struct dev to mac_device
>   net: fman: Configure fixed link in memac_initialization
>   net: fman: Export/rename some common functions
>   net: fman: memac: Use params instead of priv for max_speed
>   net: fman: Move initialization to mac-specific files
>   net: fman: Mark mac methods static
>   net: fman: Inline several functions into initialization
>   net: fman: Remove internal_phy_node from params
>   net: fman: Map the base address once
>   net: fman: Pass params directly to mac init
>   net: fman: Use mac_dev for some params
>   net: fman: Specify type of mac_dev for exception_cb
>   net: fman: Clean up error handling
>   net: fman: Change return type of disable to void
>   net: dpaa: Use mac_dev variable in dpaa_netdev_init
>   soc: fsl: qbman: Add helper for sanity checking cgr ops
>   soc: fsl: qbman: Add CGR update function
>   net: dpaa: Adjust queue depth on rate change
> 
>  .../bindings/net/fsl,fman-dtsec.yaml          | 145 +++++
>  .../devicetree/bindings/net/fsl-fman.txt      | 128 +----
>  .../net/ethernet/freescale/dpaa/dpaa_eth.c    |  59 ++-
>  .../ethernet/freescale/dpaa/dpaa_eth_sysfs.c  |   2 +-
>  drivers/net/ethernet/freescale/fman/fman.c    |  31 +-
>  drivers/net/ethernet/freescale/fman/fman.h    |  31 +-
>  .../net/ethernet/freescale/fman/fman_dtsec.c  | 325 ++++++------
>  .../net/ethernet/freescale/fman/fman_dtsec.h  |  58 +-
>  .../net/ethernet/freescale/fman/fman_keygen.c |  29 +-
>  .../net/ethernet/freescale/fman/fman_keygen.h |  29 +-
>  .../net/ethernet/freescale/fman/fman_mac.h    |  24 +-
>  .../net/ethernet/freescale/fman/fman_memac.c  | 240 +++++----
>  .../net/ethernet/freescale/fman/fman_memac.h  |  57 +-
>  .../net/ethernet/freescale/fman/fman_muram.c  |  31 +-
>  .../net/ethernet/freescale/fman/fman_muram.h  |  32 +-
>  .../net/ethernet/freescale/fman/fman_port.c   |  29 +-
>  .../net/ethernet/freescale/fman/fman_port.h   |  29 +-
>  drivers/net/ethernet/freescale/fman/fman_sp.c |  29 +-
>  drivers/net/ethernet/freescale/fman/fman_sp.h |  28 +-
>  .../net/ethernet/freescale/fman/fman_tgec.c   | 163 +++---
>  .../net/ethernet/freescale/fman/fman_tgec.h   |  54 +-
>  drivers/net/ethernet/freescale/fman/mac.c     | 497 ++----------------
>  drivers/net/ethernet/freescale/fman/mac.h     |  45 +-
>  drivers/soc/fsl/qbman/qman.c                  |  76 ++-
>  include/soc/fsl/qman.h                        |   9 +
>  25 files changed, 739 insertions(+), 1441 deletions(-)
>  create mode 100644 Documentation/devicetree/bindings/net/fsl,fman-
> dtsec.yaml
> 
> --
> 2.35.1.1320.gc452695387.dirty