Re: [PATCH v2 1/3] ads7846: don't report pressure for ads7845
From: Andy Shevchenko
Date: Fri Jul 29 2022 - 09:51:31 EST
On Thu, Jul 21, 2022 at 10:48:35PM +0200, Uwe Kleine-König wrote:
> On Thu, Jul 21, 2022 at 10:34:56AM +0200, Luca Ellero wrote:
> > From: Luca Ellero <l.ellero@xxxxxxx>
> >
> > ADS7845 doesn't support pressure.
> > This patch avoids the following error reported by libinput-list-devices:
> > "ADS7845 Touchscreen: kernel bug: device has min == max on ABS_PRESSURE".
> >
> > Signed-off-by: Luca Ellero <l.ellero@xxxxxxx>
>
> I don't know how picky Dmitry is, but some maintainers would ask you to
> either add a Signed-off-by with the email address you sent this patch
> from, or make sure to send it from the asem.it address.
It's fine to be sent from different email of the same person.
But like you said, some maintainers are really picky and that
may block contribution (I have been seen a case, where actually
allowing to do as above unblocks contribution since person can't
re-sent properly the change from another address by some reasons).
--
With Best Regards,
Andy Shevchenko