Re: [steev:linux-v5.19.0-rc8-tests 109/182] drivers/interconnect/qcom/icc-rpm.c:335:13: warning: variable 'max_peak_bw' set but not used

[Leo Yan]

Hi,

On Sun, Jul 31, 2022 at 05:43:31PM +0800, kernel test robot wrote:

[...]

> tree:   https://github.com/steev/linux linux-v5.19.0-rc8-tests
> head:   171125613e081f0d0d9aeb710dc7469ce2c6a219
> commit: 20386c070c2d12a74092d72aef1c8be37a5f5177 [109/182] interconnect: qcom: icc-rpm: Set bandwidth and clock for bucket values
> config: arm-defconfig (https://download.01.org/0day-ci/archive/20220731/202207311704.9ojLA4JI-lkp@xxxxxxxxx/config)
> compiler: arm-linux-gnueabi-gcc (GCC) 12.1.0
> reproduce (this is a W=1 build):
>         wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
>         chmod +x ~/bin/make.cross
>         # https://github.com/steev/linux/commit/20386c070c2d12a74092d72aef1c8be37a5f5177
>         git remote add steev https://github.com/steev/linux
>         git fetch --no-tags steev linux-v5.19.0-rc8-tests
>         git checkout 20386c070c2d12a74092d72aef1c8be37a5f5177
>         # save the config file
>         mkdir build_dir && cp config build_dir/.config
>         COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=arm SHELL=/bin/bash drivers/interconnect/qcom/
> 
> If you fix the issue, kindly add following tag where applicable
> Reported-by: kernel test robot <lkp@xxxxxxxxx>
> 
> All warnings (new ones prefixed by >>):
> 
>    In file included from arch/arm/include/asm/div64.h:107,
>                     from include/linux/math.h:6,
>                     from include/linux/kernel.h:25,
>                     from include/linux/clk.h:13,
>                     from drivers/interconnect/qcom/icc-rpm.c:6:
>    drivers/interconnect/qcom/icc-rpm.c: In function 'qcom_icc_set':
>    drivers/interconnect/qcom/icc-rpm.c:378:30: error: 'src_qn' undeclared (first use in this function)
>      378 |                 do_div(rate, src_qn->buswidth);
>          |                              ^~~~~~
>    include/asm-generic/div64.h:220:28: note: in definition of macro 'do_div'
>      220 |         uint32_t __base = (base);                       \
>          |                            ^~~~
>    drivers/interconnect/qcom/icc-rpm.c:378:30: note: each undeclared identifier is reported only once for each function it appears in
>      378 |                 do_div(rate, src_qn->buswidth);
>          |                              ^~~~~~
>    include/asm-generic/div64.h:220:28: note: in definition of macro 'do_div'
>      220 |         uint32_t __base = (base);                       \
>          |                            ^~~~
> >> drivers/interconnect/qcom/icc-rpm.c:335:13: warning: variable 'max_peak_bw' set but not used [-Wunused-but-set-variable]
>      335 |         u64 max_peak_bw;
>          |             ^~~~~~~~~~~

I observed on the repo https://github.com/steev/linux with the branch
"linux-v5.19.0-rc8-tests" doesn't contain the latest patch set for
"interconnect: qcom: icc-rpm: Support bucket", it contains patch:

https://github.com/steev/linux/commit/20386c070c2d12a74092d72aef1c8be37a5f5177

We can compare with Greg's char-misc.git branch, it contains patch:
https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/char-misc.git/commit/drivers/interconnect/qcom/icc-rpm.c?h=char-misc-testing&id=e3305daad62c90068e755cdae36a86ac4f02af22

I don't know how these old version patches have been merged to the
repo https://github.com/steev/linux, but it's good to sync with latest
patch set.

Thanks,
Leo