Re: [EXT] Re: [PATCH v1 2/3] dt-bindings: firmware: imx: Add imx-scu gpio node

[Marco Felsch]

On 22-08-05, Shenwei Wang wrote:
> 
> 
> > -----Original Message-----
> > From: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
> > Sent: Friday, August 5, 2022 1:56 AM
> > To: Shenwei Wang <shenwei.wang@xxxxxxx>; robh+dt@xxxxxxxxxx;
> > krzysztof.kozlowski+dt@xxxxxxxxxx; linus.walleij@xxxxxxxxxx; brgl@xxxxxxxx;
> > shawnguo@xxxxxxxxxx; s.hauer@xxxxxxxxxxxxxx; kernel@xxxxxxxxxxxxxx;
> > festevam@xxxxxxxxx; dl-linux-imx <linux-imx@xxxxxxx>
> > Cc: devicetree@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; linux-
> > gpio@xxxxxxxxxxxxxxx; linux-arm-kernel@xxxxxxxxxxxxxxxxxxx
> > Subject: [EXT] Re: [PATCH v1 2/3] dt-bindings: firmware: imx: Add imx-scu gpio
> > node
> > 
> > Caution: EXT Email
> > 
> > On 04/08/2022 20:49, Shenwei Wang wrote:
> > > Add the description for imx-scu gpio subnode.
> > >
> > > Signed-off-by: Shenwei Wang <shenwei.wang@xxxxxxx>
> > > ---
> > >  Documentation/devicetree/bindings/firmware/fsl,scu.yaml | 5 +++++
> > >  1 file changed, 5 insertions(+)
> > >
> > > diff --git a/Documentation/devicetree/bindings/firmware/fsl,scu.yaml
> > b/Documentation/devicetree/bindings/firmware/fsl,scu.yaml
> > > index b40b0ef56978..080955b6edd8 100644
> > > --- a/Documentation/devicetree/bindings/firmware/fsl,scu.yaml
> > > +++ b/Documentation/devicetree/bindings/firmware/fsl,scu.yaml
> > > @@ -30,6 +30,11 @@ properties:
> > >        Clock controller node that provides the clocks controlled by the SCU
> > >      $ref: /schemas/clock/fsl,scu-clk.yaml
> > >
> > > +  gpio:
> > > +    description:
> > > +      GPIO control over the SCU firmware APIs
> > 
> > I don't understand this description. How GPIO can control some API?
> 
> How about change to "Control the GPIO PINs on SCU domain over the firmware APIs"?

For linux it doesn't matter how the GPIOs are controlled. They can be
controlled by a co-processor like this SCU or by an I2C expander or they
are native, the list goes on. All those details are hidden.

Regards,
  Marco

> 
> Thanks,
> Shenwei
> 
> > 
> > Best regards,
> > Krzysztof