Re: [PATCH net v2 2/2] vsock: Set socket state back to SS_UNCONNECTED in vsock_connect_timeout()

[Stefano Garzarella]

On Sun, Aug 07, 2022 at 02:00:46AM -0700, Peilin Ye wrote:
> From: Peilin Ye <peilin.ye@xxxxxxxxxxxxx>
>
> Imagine two non-blocking vsock_connect() requests on the same socket.
> The first request schedules @connect_work, and after it times out,
> vsock_connect_timeout() sets *sock* state back to TCP_CLOSE, but keeps
> *socket* state as SS_CONNECTING.
>
> Later, the second request returns -EALREADY, meaning the socket "already
> has a pending connection in progress", even if the first request has
> already timed out.
>
> As suggested by Stefano, fix it by setting *socket* state back to
> SS_UNCONNECTED, so that the second request will return -ETIMEDOUT.
>
> Suggested-by: Stefano Garzarella <sgarzare@xxxxxxxxxx>
> Fixes: d021c344051a ("VSOCK: Introduce VM Sockets")
> Signed-off-by: Peilin Ye <peilin.ye@xxxxxxxxxxxxx>
> ---
> (new patch in v2)

Thanks for sending this :-)

Reviewed-by: Stefano Garzarella <sgarzare@xxxxxxxxxx>