Re: [PATCH] i2c: qcom-geni: Fix GPI DMA buffer sync-back

From: Robin Reckmann
Date: Mon Aug 08 2022 - 09:39:22 EST




On Mon, 8 Aug 2022, Wolfram Sang wrote:

On Sun, Aug 07, 2022 at 11:04:54PM +0900, Robin Reckmann wrote:
Fix i2c transfers using GPI DMA mode for all message types that do not set
the I2C_M_DMA_SAFE flag (e.g. SMBus "read byte").

In this case a bounce buffer is returned by i2c_get_dma_safe_msg_buf(),
and it has to synced back to the message after the transfer is done.

Add missing assignment of dma buffer in geni_i2c_gpi().

Set xferred in i2c_put_dma_safe_msg_buf() to true in case of no error to
ensure the sync-back of this dma buffer to the message.

Signed-off-by: Robin Reckmann <robin.reckmann@xxxxxxxxx>

Thank you! What would be a Fixes tag for this?


Thanks for having a look!

Fixes: d8703554f4de ("i2c: qcom-geni: Add support for GPI DMA")