Re: [PATCH v2 2/5] mfd: stmpe: Probe sub-function by compatible

From: Lee Jones
Date: Mon Aug 08 2022 - 11:18:22 EST


On Tue, 12 Jul 2022, Francesco Dolcini wrote:

> Use sub-function of_compatible during probe, instead of using the node
> name. The code should not rely on the node names during probe, in
> addition to that the previously hard-coded node names are not compliant
> to the latest naming convention (they are not generic and they use
> underscores), and it was broken by mistake already once [1].
>
> [1] commit 56086b5e804f ("ARM: dts: imx6qdl-apalis: Avoid underscore in node name")
>
> Suggested-by: Ahmad Fatoum <a.fatoum@xxxxxxxxxxxxxx>
> Signed-off-by: Francesco Dolcini <francesco.dolcini@xxxxxxxxxxx>
> ---
> v2:
> - remove define usage for compatible strings
> - moved rotator removal from probe to a separate patch
> ---
> drivers/mfd/stmpe.c | 11 +++++------
> 1 file changed, 5 insertions(+), 6 deletions(-)

Applied, thanks.

--
DEPRECATED: Please use lee@xxxxxxxxxx