Re: [PATCH v4 7/9] sched/fair: allow changing cgroup of new forked task
From: kernel test robot
Date: Mon Aug 08 2022 - 12:42:38 EST
Hi Chengming,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on tip/sched/core]
[also build test ERROR on linus/master next-20220808]
[cannot apply to v5.19]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Chengming-Zhou/sched-fair-task-load-tracking-optimization-and-cleanup/20220808-210012
base: https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git 8648f92a66a323ed01903d2cbb248cdbe2f312d9
config: um-i386_defconfig (https://download.01.org/0day-ci/archive/20220809/202208090027.Lo1M3CoX-lkp@xxxxxxxxx/config)
compiler: gcc-11 (Debian 11.3.0-3) 11.3.0
reproduce (this is a W=1 build):
# https://github.com/intel-lab-lkp/linux/commit/05baf61c579ea60e2b6447a012edcc5bf5f43835
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review Chengming-Zhou/sched-fair-task-load-tracking-optimization-and-cleanup/20220808-210012
git checkout 05baf61c579ea60e2b6447a012edcc5bf5f43835
# save the config file
mkdir build_dir && cp config build_dir/.config
make W=1 O=build_dir ARCH=um SUBARCH=i386 SHELL=/bin/bash
If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@xxxxxxxxx>
All errors (new ones prefixed by >>):
kernel/sched/fair.c:672:5: warning: no previous prototype for 'sched_update_scaling' [-Wmissing-prototypes]
672 | int sched_update_scaling(void)
| ^~~~~~~~~~~~~~~~~~~~
kernel/sched/fair.c: In function 'task_change_group_fair':
>> kernel/sched/fair.c:11676:27: error: 'se' undeclared (first use in this function); did you mean 'sem'?
11676 | if (!p->on_rq && !se->sum_exec_runtime)
| ^~
| sem
kernel/sched/fair.c:11676:27: note: each undeclared identifier is reported only once for each function it appears in
vim +11676 kernel/sched/fair.c
11668
11669 #ifdef CONFIG_FAIR_GROUP_SCHED
11670 static void task_change_group_fair(struct task_struct *p)
11671 {
11672 /*
11673 * We couldn't detach or attach a forked task which
11674 * hasn't been woken up by wake_up_new_task().
11675 */
11676 if (!p->on_rq && !se->sum_exec_runtime)
11677 return;
11678
11679 detach_task_cfs_rq(p);
11680
--
0-DAY CI Kernel Test Service
https://01.org/lkp